fix(harness): assign bot PRs as a soft-fail follow-up, not inline - #54
Merged
Conversation
Some bot tokens (classic PATs scoped to repo only, no read:org) can create PRs fine but have the assignee-resolution step rejected. Doing it inline via `gh pr create --assignee` meant that failure took the whole PR create down with it. Split it into create-then-assign so a scope-rejected assignment just leaves the PR unassigned (warned on stderr) instead of losing the PR. Also adds a MIGRATION.md diligence step: diff each generic file against the plugin's shipped copy before deleting it, since a hand-copied install can carry real local patches (this bug's reDeploy workaround being the concrete example) that a blanket delete would silently lose.
robercano
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some bot tokens (classic PATs scoped to
repoonly, noread:org) can create PRs fine but have the assignee-resolution step rejected. The old code appended--assigneeinline togh pr create, so that rejection took the whole PR create down with it — no PR at all. This splits it into create-then-assign: the PR always gets created, and assignment is a soft-fail follow-up (warns on stderr if it can't assign, doesn't lose the PR).Also adds a
MIGRATION.mddiligence step: diff each generic file against the plugin's shipped copy before deleting it during a hand-copied-to-plugin migration, since a local install can carry real patches (this bug's reDeploy workaround being the concrete example) that a blanket delete would silently lose.Test plan
GATES_FILE=.claude/self/gates.json gate.sh lintpassesGATES_FILE=.claude/self/gates.json gate.sh testpassesbash -n .claude/scripts/bot-gh.shsyntax-checks clean